Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Task rooting in C# and phrase list setting in all languages #1580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Task rooting in C# and phrase list setting in all languages #1580

wants to merge 2 commits into from

Conversation

v-jaswel
Copy link
Contributor

@v-jaswel v-jaswel commented Jul 19, 2022 •
edited
Loading

Purpose

Replace Task.WaitAll with Task.WaitAny in C# to match other samples.
Fix phrase list setting in all languages.
Remove phrase list setting from usage string in Go, as it is not supported there.
Add pom.xml file to Java scenario.

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@v-jaswel v-jaswel closed this Jul 19, 2022
@v-jaswel v-jaswel reopened this Jul 19, 2022
@v-jaswel
Copy link
Contributor Author

Closing and reopening to see if check bug was fixed by #1593.

@v-jaswel v-jaswel closed this Jul 28, 2022
@v-jaswel v-jaswel reopened this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargilco dargilco dargilco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-jaswel @dargilco