Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output file upload sample #272

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Output file upload sample #272

wants to merge 4 commits into from

Conversation

therahulkumar
Copy link

Updated java sample code to include example of file uploading to azure container after task completion

@msftclas
Copy link

msftclas commented Jun 22, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@therahulkumar therahulkumar mentioned this pull request Jun 22, 2019
Open
bgklein
bgklein reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like a good addition. A couple nits for sample clarity. I can't actually merge so @matthchr or @alfpark will need to take a look

Java/PoolAndResourceFile/src/main/java/PoolAndResourceFile.java Outdated Show resolved Hide resolved
Java/PoolAndResourceFile/src/main/java/PoolAndResourceFile.java Outdated Show resolved Hide resolved
Java/PoolAndResourceFile/src/main/java/PoolAndResourceFile.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgklein bgklein bgklein left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therahulkumar @msftclas @bgklein