Fix - load_workbook with read_only option when do reading #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
How did you figure it out? Is there any reason for this? In any case, that's excellent! |
|
Yep. In other words: "I should have read the fucking doc!" 🤣 |
trgiangdo
deleted the
fix/window-doesnt-close-excel-file-read-by-pandas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing test on taipy-integration-testing.
The test results can be found in Avaiga/taipy-integration-testing#67.
The reason is that the
openpyxl.load_workbook()can only be closed when the loaded file is read/write only.On MacOS and Linux, it's fine. However, on Windows, the file is not cleaned automatically, which makes the next test to fail.