Call the specific on_change when a scenario is created (#1671)

* Call the specific on_change when a scenario is created in the scenario_selector resolves #1616 * fix the test --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]>
Avaiga · Aug 14, 2024 · d6caa68 · d6caa68
1 parent daa43df
commit d6caa68
Show file tree

Hide file tree

Showing 7 changed files with 585 additions and 688 deletions.
diff --git a/frontend/taipy-gui/package-lock.json b/frontend/taipy-gui/package-lock.json
diff --git a/frontend/taipy/package-lock.json b/frontend/taipy/package-lock.json
diff --git a/frontend/taipy/src/ScenarioSelector.tsx b/frontend/taipy/src/ScenarioSelector.tsx
@@ -457,6 +457,7 @@ const ScenarioSelector = (props: ScenarioSelectorProps) => {
                     { action: props.onScenarioCrud, error_id: getUpdateVar(updateScVars, "error_id") },
                     props.onCreation,
                     props.updateVarName,
+                    props.onChange,
                     ...values
                 )
             );

diff --git a/taipy/gui_core/_context.py b/taipy/gui_core/_context.py
@@ -398,7 +398,7 @@ def get_scenario_configs(self):
     def crud_scenario(self, state: State, id: str, payload: t.Dict[str, str]):  # noqa: C901
         self.__lazy_start()
         args = payload.get("args")
-        start_idx = 2
+        start_idx = 3
         if (
             args is None
             or not isinstance(args, list)
@@ -507,7 +507,7 @@ def crud_scenario(self, state: State, id: str, payload: t.Dict[str, str]):  # no
                 if (scenario or user_scenario) and (sel_scenario_var := args[1] if isinstance(args[1], str) else None):
                     try:
                         var_name, _ = gui._get_real_var_name(sel_scenario_var)
-                        state.assign(var_name, scenario or user_scenario)
+                        self.gui._update_var(var_name, scenario or user_scenario, on_change= args[2])
                     except Exception as e:  # pragma: no cover
                         _warn("Can't find value variable name in context", e)
         if scenario:

diff --git a/tests/gui_core/test_context_is_deletable.py b/tests/gui_core/test_context_is_deletable.py
@@ -58,6 +58,7 @@ def test_crud_scenario(self):
                 "",
                 {
                     "args": [
+                        "",
                         "",
                         "",
                         True,
@@ -78,6 +79,7 @@ def test_crud_scenario(self):
                     "",
                     {
                         "args": [
+                            "",
                             "",
                             "",
                             True,

diff --git a/tests/gui_core/test_context_is_editable.py b/tests/gui_core/test_context_is_editable.py
@@ -57,6 +57,7 @@ def test_crud_scenario(self):
                 "",
                 {
                     "args": [
+                        "",
                         "",
                         "",
                         True,
@@ -75,6 +76,7 @@ def test_crud_scenario(self):
                     "",
                     {
                         "args": [
+                            "",
                             "",
                             "",
                             True,

diff --git a/tests/gui_core/test_context_is_readable.py b/tests/gui_core/test_context_is_readable.py
@@ -107,6 +107,7 @@ def test_crud_scenario(self):
                 "",
                 {
                     "args": [
+                        "",
                         "",
                         "",
                         True,
@@ -125,6 +126,7 @@ def test_crud_scenario(self):
                     "",
                     {
                         "args": [
+                            "",
                             "",
                             "",
                             True,