-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] If a deeplink is malformed or missing data we show auth screen. #1673
Conversation
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
@notandyvee @danilo04 I'm working on more release automation and aim to have a quick 2.34 release to test it, see p1725313949594039-slack-C036Y8QL4 It would be great to get this reviewed so we can make it part of it? I'll make sure to track here when the release starts, so that we can adjust the base branch accordingly:
Thanks! |
@notandyvee @danilo04 FYI, I merged Also, given the release 2.34 code freeze has started, I updated the target branch for this PR to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected @notandyvee. Good job
Fix
There is an edge case with magic link deeplinking. If the url is malformed or the client cannot properly find the email/code as an example, the app doesn't ever show up. You do see a toast, but this is weird behavior. This PR updates that so that we show the auth activity in this case.
Additionally, while I was here I realize the magic link on this screen was missing a loading indicator. It's not clear this is happening. On slower networks this could be an issue. A loading dialog will do for now.
Test
What I did to test is to put this link in google keep:
https://app.simplenote.com/login?email=&auth_code=0V6GUL
. You can open the link and it will trigger the deeplink. Do not paste it on chrome. Doing that ignores any deeplink.Release
N/A