Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atmosphere-spring brings support for Spring 4.
With the current code, it is almost impossible to integrate atmosphere-spring into a Spring 3 project due to a missing method in
BeanFactory
(i.e.ApplicationContext
) which was added in Spring 4.1:<T> T getBean(Class<T> requiredType, Object... args) throws BeansException;
This PR replaces the use of
T getBean(Class<T> requiredType, Object... args)
byObject getBean(String name, Object... args)
, which has been around since Spring 2.5. This way, you can also use atmosphere-spring with older Spring versions.Changing the property
spring-version
to 3.2.x is not mandatory but might help to assert future changes won't break compatibility with Spring 3.