Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only stop places checkbox in location search #4719

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gorandalum
Copy link
Member

@gorandalum gorandalum commented Sep 20, 2024

Background

When looking at geocoder request logs, we see that only ~8% of
location searches end up in the user selecting an address. They
instead use my position or a stop place.

It was decided to do a proof of concept by swiftly adding a checkbox,
and get quick feedback on whether this is a feature that users will use
or not.

Solution

To make searching for stop places easier we add a checkbox the user
can check so only stop places are returned when searching for a
location. We will enable this to a subset of the users, and see if
it is a feature which will be used.

Acceptance criteria

  • If the is not checked, both stop places and other locations are returned.
  • If the checkbox is checked, then only stop places are returned.
  • When toggling the checkbox, a PostHog event is sent ('Location search'/'Only stop places checkbox pressed').
  • The checkbox is only shown if enable_only_stop_places_checkbox evaluates to true in RemoteConfig
  • When using debug override, the setting in RemoteConfig is overridden

When looking at geocoder request logs, we see that only ~8% of
location searches end up in the user selecting an address. They
instead use my position or a stop place.

To make searching for stop places easier we add a checkbox the user
can check so only stop places are returned when searching for a
location. We will enable this to a subset of the users, and see if
it is a feature which will be used.
Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@gorandalum gorandalum merged commit 3f6bd01 into master Sep 20, 2024
4 checks passed
@gorandalum gorandalum deleted the dalum/only_stop_places_checkbox branch September 20, 2024 11:00
@tormoseng
Copy link
Member

Note to after release of 1.57:

  • Make PostHog dashboard for event Location search: Only stop places checkbox pressed with cheked: true | false
  • Look on Grafana for requests with layers=venue like /bff/v1/geocoder/features?lat=63.43119807409924&layers=venue&

@tormoseng
Copy link
Member

✅ Tested OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants