fix: updating the wrong departure in favorite departures with realtim…

…e data (#3699)
AtB-AS · Jun 30, 2023 · bfc7da6 · bfc7da6
1 parent beb13d3
commit bfc7da6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/departure-list/utils.ts b/src/departure-list/utils.ts
@@ -10,7 +10,6 @@ import {DepartureRealtimeData, DeparturesRealtimeData} from '@atb/sdk';
 import {isNumberOfMinutesInThePast} from '@atb/utils/date';
 
 export const HIDE_AFTER_NUM_MINUTES = 1;
-
 /***
  * Used to update all stops with new time from realtime mapping object returned
  * from the BFF. It also removes outdated departures which most likely have passed.
@@ -83,7 +82,10 @@ function updateDeparturesWithRealtime(
 
       const departureRealtime = realtime.departures[serviceJourneyId];
 
-      if (!departureRealtime) {
+      if (
+        !departureRealtime ||
+        departure.aimedTime !== departureRealtime.timeData.aimedDepartureTime
+      ) {
         return departure;
       }
 

diff --git a/src/sdk.ts b/src/sdk.ts
@@ -178,6 +178,7 @@ export type RealtimeData = {
   timeData: {
     realtime: boolean;
     expectedDepartureTime: string;
+    aimedDepartureTime: string;
   };
 };