Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #325

Merged
merged 30 commits into from
Feb 19, 2024
Merged

chore: upgrade dependencies #325

merged 30 commits into from
Feb 19, 2024

Conversation

rosvik
Copy link
Member

@rosvik rosvik commented Feb 9, 2024

closes https://github.com/AtB-AS/kundevendt/issues/16263

My todolist, with descriptions, if anyone is interested

BFF dependencies (dev)

  • "@graphql-codegen/cli": "^2.4.0",
  • "@graphql-codegen/near-operation-file-preset": "^2.2.3",
  • "@graphql-codegen/typescript": "^2.4.2",
  • "@graphql-codegen/typescript-generic-sdk": "^2.3.1",
  • "@graphql-codegen/typescript-operations": "^2.2.2",
  • "@types/geojson": "^7946.0.14",
  • "@types/hapi__catbox-memory": "^4.1.8",
  • "@types/hapi__catbox-redis": "^5.0.10",
    • Removed, as types are included in package
  • "@types/hapi__hapi": "^20.0.13",
    • Removed, as types are included in package
  • "@types/hapi__inert": "^5.2.2",
    • Causes upgrade to "@hapi/hapi": "^21.1.0"
    • Removed, as types are included in package
  • "@types/hapi__vision": "^5.5.7",
    • Causes upgrade to "@hapi/hapi": "^21.1.0"
    • Removed, as types are included in package
  • "@types/jest": "^26.0.20",
  • "@types/lodash.groupby": "^4.6.9",
  • "@types/lodash.sortby": "^4.7.9",
  • "@types/lodash.union": "^4.6.9",
  • "@types/logfmt": "^1.2.6",
  • "@types/lz-string": "^1.3.34",
  • "@types/mapbox__polyline": "^1.0.5",
  • "@types/node": "^16.18.3",
  • "@types/node-fetch": "^2.5.8",
  • "@types/uuid": "^8.3.0",
  • "@typescript-eslint/eslint-plugin": "^5.59.9",
  • "@typescript-eslint/parser": "^5.59.9",
  • "copyfiles": "^2.4.1",
  • "eslint-config-prettier": "^8.8.0",
  • "eslint-plugin-prettier": "^4.2.1",
  • "eslint-plugin-unused-imports": "^2.0.0",
  • "jest": "^26.6.3",
  • "nodemon": "^2.0.7",
  • "prettier": "^2.2.1",
  • "ts-jest": "^26.5.3",
  • "ts-node": "^10.9.2",
  • "typescript": "^4.2.3"

BFF dependencies (non-dev)

To prevent the yak shave of upgrading the BFF to a ESM, this patch
upgrades node-fetch to 2.7.0, which is currently the last version before
it becomes a ESM only module. More info on upgrading further here:
https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md#converted-to-es-module

The same problem also caps our p-throttle version at 4.1.1:
https://github.com/sindresorhus/p-throttle/releases/tag/v5.0.0
Seems like this was implicitly included by other packages, and not
declared as an actual dependency.
This is due to a requirement in p-limit
@rosvik rosvik marked this pull request as ready for review February 9, 2024 13:53
@rosvik rosvik removed the request for review from KristianSelnas February 9, 2024 14:07
Copy link
Member

@jorelosorio jorelosorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, nice work, I tried the most common task like start, build and seem to at least do not break, and I am pretty sure you tested it locally :).

There is a minor comment: Dockerfiles seem to point still to old node versions.

@rosvik
Copy link
Member Author

rosvik commented Feb 9, 2024

@jorelosorio

Dockerfiles seem to point still to old node versions.

Good point!

  • lts-slim, which is used in Dockerfile, points to node 20, which works fine.
  • Dockerfile.test points to another node project, that I didn't really touch in this PR, but to keep things more consistent I updated Dockerfile.test to 18-alpine, since node 20 seems to break the tests. (cc. @tormoseng)

@rosvik
Copy link
Member Author

rosvik commented Feb 13, 2024

Waiting for 1.47 release before I merge this

@rosvik rosvik merged commit b0ee96c into main Feb 19, 2024
@rosvik rosvik deleted the rosvik/update-dependencies branch February 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants