Basic x112virtgpu support #72
Open
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With DAX, we have coherent mmap with the host. Sharing /dev/shm means that POSIX shared memory will work across the VM boundary. Signed-off-by: Asahi Lina <[email protected]>
This lets us easily test this alternative to sommelier+XWayland without committing to making it the default.
asahilina
requested review from
slp,
teohhanhui and
alyssarosenzweig
as code owners
alyssarosenzweig
approved these changes
Oct 3, 2024
slp
requested changes
Oct 4, 2024
| @@ -144,5 +145,21 @@ pub fn mount_filesystems() -> Result<()> { | |||
| make_tmpfs("/tmp/.X11-unix")?; | |||
| } | |||
|
|
|||
| // Check for DAX active on the root filesystem (first line of /proc/mounts should be the root FS) | |||
| let has_dax = std::fs::read_to_string("/proc/mounts")? | |||
There was a problem hiding this comment.
I think we should either move this check to muvm-guest.rs or have this method return has_dax so we can avoid doing the same check again in setup_x11_forwarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the trivial X11 socket passthrough with x112virtgpu, if it is installed and DAX is enabled. This lives alongside the existing sommelier solution, so we can test both options for now.