fix: explicit use bash for update-grub #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: b-crumb <[email protected]>
Signed-off-by: b-crumb <[email protected]>
I use dash as /bin/sh on my system. Actual script is not posix compliant some piece of code are bash only, I propose to just force /bin/bash here. Or we should convert them all to posix, in case some people, use dash for example. Signed-off-by: Cyril Levis <[email protected]>
cyrinux
force-pushed
the
fix/update-grub
branch
from
4ae9d35
to
b7f12bb
Compare
|
+1, also had to patch this in my Ubuntu package. |
|
I think also update-m1n1 is bash specific? |
|
@dkwo indeed |
|
Actually i think i was wrong. For me, the issue is that m1n1.conf needs to have an end of line, otherwise it is not processed. i'm using a slightly modified version, but it works with /bin/sh on void, which is dash i think. the example in the wiki is bash though, with the <(.. construct. |
|
it was reported that also asahi-diagnose has bashisms, do you mind changing its to bash as well in this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use dash as /bin/sh on my system.
Actual script is not posix compliant some piece of code are bash only, I propose to just force /bin/bash here.
Or we should convert them all to posix, in case some people, use dash for example.