Avoid redundant validation of child objects when saving the parent.

R/AllGenerics.R

@@ -70,10 +70,24 @@ setGeneric("saveObject", function(x, path, ...) {
         }
     }
 
+    # Only validate once we're outside of nested calls, as each parent should
+    # validate its children; separate validation of each child is redundant.
+    do_validate <- !is_nested$status
+    if (do_validate) {
+        is_nested$status <- TRUE
+        on.exit({ is_nested$status <- FALSE }, add=TRUE, after=FALSE)
+    }
+
     standardGeneric("saveObject")
-    validateObject(path)
+
+    if (do_validate) {
+        validateObject(path)
+    }
 })
 
+is_nested <- new.env()
+is_nested$status <- FALSE
+
 #######################################
 ########### OLD STUFF HERE ############
 #######################################

tests/testthat/test-DataFrame.R

@@ -130,10 +130,10 @@ test_that("staging of weird objects within DFs works correctly", {
 
     # Works in the new world.
     tmp2 <- tempfile()
-    saveObject(df, tmp2)
+    saveObject(input, tmp2)
     expect_identical(readObjectFile(tmp2)$type, "data_frame")
     round2 <- readDataFrame(tmp2)
-    expect_identical(round2, df)
+    expect_identical(round2, input)
 })
 
 test_that("staging of uncompressed Gzip works correctly", {