Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ark-metadata): refactor metadata crate #90

Merged
merged 48 commits into from
Sep 22, 2023
Merged

feat(ark-metadata): refactor metadata crate #90

merged 48 commits into from
Sep 22, 2023

Conversation

remiroyc
Copy link
Contributor

@remiroyc remiroyc commented Sep 13, 2023 •
edited
Loading

Overview

Refactor the ark-metadata crate and introduce a MetadataManager that manages metadata associated with tokens. This manager fetches and updates token metadata, interfacing with the underlying storage and the Starknet client.

It fixes #80

TODO

@remiroyc remiroyc marked this pull request as draft September 13, 2023 10:23
Base automatically changed from global-flow to main September 13, 2023 16:29
@remiroyc remiroyc force-pushed the feat/metadata-refactor branch 2 times, most recently from 2c50a28 to bc74415 Compare September 15, 2023 00:18
@remiroyc remiroyc changed the title feat(metadata): global refactor refactor(metadata): new metadata crate Sep 15, 2023
@remiroyc remiroyc force-pushed the feat/metadata-refactor branch 8 times, most recently from e611c83 to f5b0ed4 Compare September 15, 2023 08:36
@remiroyc remiroyc changed the title refactor(metadata): new metadata crate Refactor metadata crate Sep 15, 2023
@remiroyc remiroyc changed the title Refactor metadata crate Refactor metadata Sep 15, 2023
@remiroyc remiroyc marked this pull request as ready for review September 20, 2023 15:42
@remiroyc remiroyc changed the title Refactor metadata Create metadata crate Sep 20, 2023
@remiroyc remiroyc changed the title Create metadata crate Create Metadata Crate Sep 20, 2023
@remiroyc remiroyc changed the title Create Metadata Crate feat(ark-metadata): refactor metadata crate Sep 20, 2023
@remiroyc remiroyc force-pushed the feat/metadata-refactor branch 3 times, most recently from a7ffe4d to 73eb387 Compare September 20, 2023 16:00
glihm
glihm reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, super nice for the testing mate. 💪

Some comments not that much, but we should revise the rust standards we all have to use to ensure we can make the code base evolve and easier to maintain. 👍

crates/ark-metadata/src/cairo_string_parser.rs Outdated Show resolved Hide resolved
crates/ark-metadata/src/metadata.rs Outdated Show resolved Hide resolved
crates/ark-storage/src/types.rs Outdated Show resolved Hide resolved
crates/ark-metadata/src/metadata_manager.rs Show resolved Hide resolved
crates/ark-metadata/src/metadata_manager.rs Outdated Show resolved Hide resolved
crates/ark-metadata/src/metadata_manager.rs Outdated Show resolved Hide resolved
crates/ark-metadata/src/metadata_manager.rs Outdated Show resolved Hide resolved
@remiroyc remiroyc changed the title feat(ark-metadata): refactor metadata crate feat(ark-metadata): refactor metadata crate 🖼️ Sep 21, 2023
@remiroyc remiroyc changed the title feat(ark-metadata): refactor metadata crate 🖼️ feat(ark-metadata): refactor metadata crate Sep 21, 2023
kwiss
kwiss approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@kwiss kwiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me with the latest changes

glihm
glihm approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @remiroyc!

@glihm glihm merged commit caf262d into main Sep 22, 2023
4 checks passed
@remiroyc remiroyc deleted the feat/metadata-refactor branch September 26, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiss kwiss kwiss approved these changes

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store token images on AWS S3
3 participants
@remiroyc @kwiss @glihm