Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

World Scenes #18

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

World Scenes #18

wants to merge 15 commits into from

Conversation

andersonmmachado
Copy link

Added 8 custom worlds for unity (Hospital, Kantine, Warehouse, School, Japan garden, Office, Small house and Restaurant).
All worlds have baked lights and high definition materials for better visuals.

andersonmmachado and others added 14 commits January 4, 2024 20:01
@andersonmmachado
-Added 7 Worlds:
0e92abd 
-Apartament
-Hospital(Similar to Gazebo)
-Office(Similar to Gazebo)
-Restaurant
-School
-Simple Dynamic World(Similar to Gazebo)
-Small House

-lighting and reflections onlz working on the Hospital world
@andersonmmachado
Merge branch 'main' of https://github.com/andersonmmachado/arena-unity …
5169180 
…into WorldGen
@andersonmmachado
update from arena-unitz
60a4a44
@andersonmmachado
lights and reflections added for School and Office
8b7a50d
@andersonmmachado
-better materials and lights for school, hospital and office
a411bfa 
-baked light and reflection added for restaurant
@andersonmmachado
Merge branch 'main' of https://github.com/andersonmmachado/arena-unity …
ae435b5 
…into WorldGen
@andersonmmachado
- Better lights
2fc0e1c
@andersonmmachado
Merge branch 'Arena-Rosnav:main' into WorldGen
b53077c
@andersonmmachado
New worlds:
572b5e3 
Office better assets
Japan garden
@andersonmmachado
New world: Warehouse
97bd067
@andersonmmachado
Japan Garden and better Graphics
91095af
@andersonmmachado
Merge branch 'main' of https://github.com/andersonmmachado/arena-unity …
e9170cd 
…into WorldGen
@andersonmmachado
-Reduced size of models.
b7c678e 
-School modified
-baked scenes
All Words done
@andersonmmachado
Kantine added
5e7f848
@ddiaz-0
Copy link
Collaborator

ddiaz-0 commented May 3, 2024

The different Worlds/Scenes look very good. Maybe still need some of your light adjustment @bowski23, especially regarding reflections and overall brightness, and some material rework (sometimes too metallic/glossy look/strong reflections: Hospital/Cantine/Office/Small House). I also tested this PR #18 merged with PR #16 but setting map_file to one of these worlds doesn't launch the corresponding scene because arena-rosnav doesn't know about the map (maps are loaded from worlds/ in simulation-setup).
I think we would have to create a new world in the simulation setup repo and a default scenario too, for it to work with arena rosnav. But still then I'm not sure how we would tell arena rosnav that those worlds only work for unity and not other 3d simulators (gazebo). Correct me if I'm wrong?
Estimated additional git repository size is around 8GB btw. Didn't notice any changes in the startup time of arena-rosnav+unity tho.

@voshch
Merge remote-tracking branch 'origin/main' into WorldGen
71783cd 
# Conflicts:
#	Assets/Scenes/SampleScene/Settings/QualityLevels/2HDRPMediumQuality.asset
@voshch voshch requested a review from bowski23 September 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximilianSchreff MaximilianSchreff Awaiting requested review from MaximilianSchreff

@ddiaz-0 ddiaz-0 Awaiting requested review from ddiaz-0

@bowski23 bowski23 Awaiting requested review from bowski23

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersonmmachado @ddiaz-0 @voshch