Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Planner - Choose how to access the map tiles : server, cache or both #3319

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Godeffroy
Copy link
Contributor

@Godeffroy Godeffroy commented Apr 3, 2024

  • Add ComboBox in ConfigPlanner to choose if map is loaded from cache only, server only or cache and server (default). This setting is saved in the config.xml

  • Add button in ConfigPlanner to Open Map Cache Folder

  • SRTM files are downloaded if GMaps Access Mode is not CacheOnly

image

This greatly reduces cpu load and unnecessary network access in case of using an offline GCS.

I don't know if i need to modify all ConfigPlanner.resx file's language as well ?

@EosBandi
Copy link
Collaborator

EosBandi commented Apr 3, 2024

  • Is there any reason why not simple check if we have network connectivity and set the mode based on the result ? A permanent setting has a risk that user forgot it in offline mode and expects that once connected to a network it will download srtm/maptiles.
  • There are already an "Age Map" function in the ctrl-f screen, if a user really want to delete the whole cache (including the database) then he/she must know where to find it :) Even if it needed, the the right place to put it is the ctrl-f screen, alongside with the other housekeeping and experimental functions.

@Godeffroy
Copy link
Contributor Author

Thanks for you response !
I plan to do another PR on the prefetch feature to make it faster, i can also add this : before prefetching, it switch whatever mode it is to ServerAndCache ?
And another PR on the inject GE as it will be possible to easily inject png, jpeg and jpg with a progress bar, change map provider to custom and map access mode to CacheOnly.

Add ComboBox in ConfigPlanner to choose if map is loaded from cache only, server only or cache and server (default). This setting is saved in the config.xml
Add button in ConfigPlanner to Open Map Cache Folder
SRTM files are downloaded if GMaps Access Mode is not CacheOnly
@Godeffroy
Copy link
Contributor Author

Rebased on master

@meee1 meee1 merged commit 4db6497 into ArduPilot:master Sep 18, 2024
6 checks passed
@Godeffroy Godeffroy deleted the Load_offline_maps branch September 18, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants