Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightPlanner: Simultaneous Display of Mission, Geofence, and Rally Points in PLAN Screen #3310

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tatsuy
Copy link
Contributor

@tatsuy tatsuy commented Mar 12, 2024

simultaneous display of all elements—missions, fences, and rally points

Changes:

  • Maintain the current dropdown menu for selecting the primary editable item ("MISSION", "FENCE", or "RALLY").
  • The selected item from the dropdown menu would be displayed in an editable mode, allowing users to add, remove, or modify points as currently possible.
  • Items not selected in the dropdown menu would be displayed in a read-only mode. This would allow users to see all elements (mission waypoints, geofence boundaries, and rally points) overlaid on the map simultaneously, but only edit the item type they have selected from the dropdown menu.

Resolved these issues #3300 and #3305.

image

@EosBandi
Copy link
Collaborator

It works only when you are connected to a vehicle and changes are uploaded to the vehicle.
Not working in offline mode.

@tatsuy
Copy link
Contributor Author

tatsuy commented Mar 12, 2024

Implementing the logic for offline mode will require additional work, and it seems it might take some time to properly address. Therefore, I've decided to split the PRs. This PR addresses the functionality only when connected to a vehicle. The offline mode functionality will be tackled in a future update.

@tatsuy
Copy link
Contributor Author

tatsuy commented Mar 14, 2024

@EosBandi
I've updated the implementation to support simultaneous display even when not connected to a vehicle, addressing the offline mode functionality. Feedback is always welcome!

@tatsuy
Copy link
Contributor Author

tatsuy commented Apr 23, 2024

@meee1 @EosBandi
I want to use this feature in the next lastest release.
Could someone test this for merging?

@rmackay9
Copy link
Contributor

Coincidentally a user just asked for this on the Rover-4.5 forums here https://discuss.ardupilot.org/t/change-fence-enable-during-mission/116690/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants