Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigRawParams: Various bugfixes #3246

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

robertlong13
Copy link
Collaborator

@robertlong13 robertlong13 commented Nov 29, 2023

  1. Add double buffering to MyDataGridView. Prevents dangerous graphical corruption that can occur when scrolling, causing the name of the parameter you are editing to look like a different parameter. See this example; the CAN_P1_BITRATE parameter is falsely labeled as CAN_LOGLEVEL:
    image
  2. Fix an off-by-one error on a row-check that broke additional controls, like the bitmask button, on row 1
    image
  3. Stop the tree view from taking favorites into account:
    image

Fixes serious graphical corruption that can happen sometimes when scrolling
Additional options like the dropdown box or bitmask button would not show
up for the first row
@robertlong13
Copy link
Collaborator Author

robertlong13 commented Sep 17, 2024

@meee1, I'd really like to get this one in. Number-1 in this list can actually be pretty dangerous in the wrong circumstances (like accidentally changing a tuning value when you are trying to change a different nearby parameter).

@meee1 meee1 merged commit c3c8475 into ArduPilot:master Sep 17, 2024
5 of 6 checks passed
@robertlong13 robertlong13 deleted the pr/config_raw_param_fixes branch September 21, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants