CommsUDPSerialConnect multicast to allow address reuse #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meee1
reviewed
Jul 6, 2023
| client = new UdpClient(); | ||
| client.ExclusiveAddressUse = false; | ||
| client.Client.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true); | ||
| client.Connect(hostEndPoint.Address, hostEndPoint.Port); |
There was a problem hiding this comment.
this actually removes the bind port, and changes to a connect vs a bind and listen
There was a problem hiding this comment.
Exactly. We don't want to bind. We want two apps to be able to use the same multicast ip and port. If you don't like that, I suppose we could add a checkbox to enable/allow port-reuse in the CoT menu
|
This is the checkbox in WinTAK to enable this |
magicrub
commented
Oct 19, 2023
| @@ -171,7 +171,7 @@ void mainloop() | |||
|
|
|||
| if (CoTStream != null && CoTStream.IsOpen) | |||
| { | |||
| CoTStream.WriteLine(xmlStr.Replace("\r", "")); | |||
There was a problem hiding this comment.
I can't remember why I added this but it doesn't really do anything and doesn't belong in this PR.
|
I'd also like to suggest having an option to ALWAYS do this, with a checkbox in the Config->Planner page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending to a multicast port, such as 234.2.3.1:6969 for TAK, other apps on the same computer can't use that same multicast IP. Example: using WinTAK to test TAK messages from Mission Planner. There's an option in WinTAK networking settings to allow this, but for Mission Planner I think it's fine to always allow it