Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deb builder for ArduPilot version #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

khancyr
Copy link

@khancyr khancyr commented Jun 4, 2024

add a simple way to create a deb file for the generator

also add a release build workflow. To trigger it, just create a github release with a tag and it will build the deb and put it as release artefact

@khancyr khancyr force-pushed the feature/debbuilder branch 2 times, most recently from 59aa0e0 to af4438e Compare June 4, 2024 22:24
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jun 4, 2024

Nice! Should this go upstream? They already build debs.

@@ -0,0 +1,12 @@
Package: ap-microxrceddsgen
Version: 0.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally,this matches the version of the tool. Currently, it's not set, but official releases will have a version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, we can update this one, when you use the build script it update the Version to the right one's

echo "Usage: $0 <version>"
exit 1
fi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set -euf -o pipefail

Catch errors earlier with this protection in shell.


- uses: ./src/microxrceddsgen/.github/actions/install-apt-packages

- name: Get minimum supported version of CMake
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need cmake to build it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the current ci rules, I think it is used for the test as it download dds clients

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v3
- uses: actions/checkout@v4

v3 is EOL soon I think

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 11, 2024

@khancyr Got any time to finish this up? It's really great.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 11, 2024

A great next step would be to put this on an apt repo so we can have people apt install ardupilot-microxrceddsge.

https://github.com/rpatterson/github-apt-repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants