feat: 🎸 refactor ERC721STD, script to generate data for STS dep #39
oleggribAnnotations
10 errors, 13 warnings, and 10 notices
|
solhint:
contracts/package/attestation/AsnDecode.sol#L14
'decodeLength' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L32
'copyDataBlock' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L75
'decodeElementOffset' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L87
'decodeDERData' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L94
'decodeDERData' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L115
'copyStringBlock' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L158
'decodeElement' should start with _
|
|
solhint:
contracts/package/attestation/AsnDecode.sol#L165
'decodeIA5String' should start with _
|
|
solhint:
contracts/package/attestation/IdAttest.sol#L12
'TTL_GAP' should start with _
|
|
solhint:
contracts/package/attestation/IdAttest.sol#L13
'INTEGER_TAG' should start with _
|
|
1-0-write-after-write:
contracts/package/attestation/VerifyAttestation.sol#L205
VerifyAttestation.recoverTicketSignatureAddress(bytes,uint256).length (contracts/package/attestation/VerifyAttestation.sol#205) is written in both
|
|
3-1-dead-code:
contracts/package/attestation/AsnDecode.sol#L165
AsnDecode.decodeIA5String(bytes,uint256[],uint256,uint256) (contracts/package/attestation/AsnDecode.sol#165-180) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/attestation/Utils.sol#L30
Utils.bytesToHex(bytes) (contracts/package/attestation/Utils.sol#30-42) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/tokens/ERC721OptimizedEnumerableUpgradeable.sol#L47
ERC721OptimizedEnumerableUpgradeable._prepareTokenId() (contracts/package/tokens/ERC721OptimizedEnumerableUpgradeable.sol#47-51) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/attestation/VerifyAttestation.sol#L166
VerifyAttestation.verifyEqualityProof(bytes,bytes,bytes,bytes) (contracts/package/attestation/VerifyAttestation.sol#166-185) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/tokens/extensions/Minter.sol#L20
Minter._ownerOf(uint256) (contracts/package/tokens/extensions/Minter.sol#20) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/tokens/ERC721STD.sol#L64
ERC721STD._increaseBalance(address,uint128) (contracts/package/tokens/ERC721STD.sol#64-66) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/tokens/ERC721OptimizedEnumerableUpgradeable.sol#L118
ERC721OptimizedEnumerableUpgradeable._mint(address) (contracts/package/tokens/ERC721OptimizedEnumerableUpgradeable.sol#118-121) is never used and should be removed
|
|
3-1-dead-code:
contracts/package/attestation/VerifyAttestation.sol#L265
VerifyAttestation.mapTo256BitInteger(bytes) (contracts/package/attestation/VerifyAttestation.sol#265-268) is never used and should be removed
|
|
3-0-solc-version:
contracts/package/access/UriChanger.sol#L3
Pragma version^0.8.16 (contracts/package/access/UriChanger.sol#3) allows old versions
|
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
solhint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
solhint:
contracts/helpers/ExampleERC721.sol#L12
Line length must be no more than 120 but current length is 122
|
|
solhint:
contracts/helpers/ExampleERC721.sol#L60
Line length must be no more than 120 but current length is 125
|
|
solhint:
contracts/package/attestation/IdAttest.sol#L52
Line length must be no more than 120 but current length is 122
|
|
solhint:
contracts/package/attestation/IdAttest.sol#L54
Line length must be no more than 120 but current length is 142
|
|
solhint:
contracts/package/attestation/IdAttest.sol#L95
Line length must be no more than 120 but current length is 147
|
|
solhint:
contracts/package/attestation/Pok.sol#L108
Line length must be no more than 120 but current length is 139
|
|
solhint:
contracts/package/attestation/Pok.sol#L112
Line length must be no more than 120 but current length is 153
|
|
solhint:
contracts/package/attestation/Pok.sol#L117
Line length must be no more than 120 but current length is 137
|
|
solhint:
contracts/package/attestation/VerifyAttestation.sol#L73
Line length must be no more than 120 but current length is 201
|
|
solhint:
contracts/package/attestation/VerifyAttestation.sol#L219
Line length must be no more than 120 but current length is 139
|
|
slither
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|