feat: improve synchronization #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rushiiMachine
commented
Sep 10, 2024
rushiiMachine
commented
- Don't lock everything when hooking different methods
- Don't sort callbacks for no reason
- Other micro-optimizations
|
like i told you on discord, these changes makes very little sense your new hookMethod is overly overcomplicated and has multiple potentials for data races. and the synchronisation on adding hooks is not performance relevant as an application is only gonna add a few hundred hooks your changes to CopyOnWriteSortedSet also make no sense. why remove the deduplication? why rename it? why make indexOf static? based on the PR title I assume you think this will improve performance but this structure is only used to store patches for one method, and thus will never exceed a few dozen elements, so the indexOf for deduplication is virtually free overall this just makes code more complicated and arguably worse for incredibly minimal microoptimisations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.