Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category of elements for general C-sets #818

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Category of elements for general C-sets #818

merged 2 commits into from
Jul 13, 2023

Conversation

kris-brown
Copy link
Contributor

There was an unnecessarily strict typing on the the argument to elements which required it to be a StructACSet - this PR relaxes that constraint.

@kris-brown kris-brown changed the title Category of elements for general acsets Category of elements for general c-sets Jun 28, 2023
@aaguinal
Copy link
Contributor

aaguinal commented Jul 7, 2023

Any chance we can bump this up in the merge queue? Thank you!

@epatters epatters changed the title Category of elements for general c-sets Category of elements for general C-sets Jul 13, 2023
epatters
epatters approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@epatters epatters merged commit 847aad0 into AlgebraicJulia:main Jul 13, 2023
11 checks passed
@kris-brown kris-brown deleted the elements_dynamic branch July 18, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees
No one assigned
Labels
acsets cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kris-brown @aaguinal @epatters