Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EXISTS Function for Subqueries (Issue #1904) #1939

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix EXISTS Function for Subqueries (Issue #1904) #1939

merged 1 commit into from
Jul 8, 2024

Conversation

Midwayne
Copy link
Contributor

Changes Made:

  • Updated yy.ExistsValue class in 41exists.js to correctly handle EXISTS function in subqueries.
  • Adjusted toJS method to return a boolean value based on the presence of data in the subquery result.

Testing:

  • All tests passed successfully when executed with yarn test.

Related Issue:
This pull request addresses issue #1904.

mathiasrw
mathiasrw approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mathiasrw mathiasrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add a test file for this issue so we know if we

src/41exists.js Show resolved Hide resolved
@mathiasrw mathiasrw merged commit aeb3b00 into AlaSQL:develop Jul 8, 2024
10 checks passed
@mathiasrw
Copy link
Member

Released as part of v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasrw mathiasrw mathiasrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Midwayne @mathiasrw