Use ESP32's AsyncUDP when ESPALEXA_ASYNC requested #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on an ESP32 and choosing ESPALEXA_ASYNC, this PR changes the UDP implementation to async as well as TCP/web server. This change solves a memory fragmentation issue for ESP32 devices that results in WiFiUdp's parsePacket getting memory allocation errors causing CPU restarts. The async model also fixes the "flush" problem reported in PR#181 dropping packets since the async model delivers all packets it receives even on busy networks.
Fix debug buffer dump overflow and tweak debugging output
Added an option for subnet filtering to avoid SSDP attack, fixed a light number issue in the state command response, tweaked debugging and added separate define to view all SSDP packet contents to limit debug log spamming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on an ESP32 and choosing ESPALEXA_ASYNC, this PR changes the UDP implementation to async as well as TCP/web server. This change solves a memory fragmentation issue for ESP32 devices that results in WiFiUdp's parsePacket getting memory allocation errors causing CPU restarts. The async model also fixes the "flush" problem reported in PR#181 dropping packets since the async model delivers all packets it receives even on busy networks.