Resolve issue #60 with mangled variable.

[jfparadis]

Prevent mangling of variables.
#60
Changes:

• Keep cleanupSource for builds.
• Use minimized UMD in demo.
• Integration tests.

[michaelfig]

globalEval was needed to prevent ESM from mangling the (1,eval) form. Please see #54 (which incorrectly cites rollup as the cause) and test that importing realms-shim under ESM using your PR with SES can create a root realm.

We may need to find a different solution for rollup only.

[Jack-Works]

Can use const globalEval = Math.random()>-1?eval: undefined Instead of (1, eval) Michael FIG <[email protected]> 于 2019年10月1日周二 上午11:45写道：

…

globalEval was needed to prevent ESM from mangling the (1,eval) form. Please see #54 <#54> (which incorrectly cites rollup as the cause) and test that importing realms-shim under ESM using your PR with SES can create a root realm. We may need to find a different solution for rollup only. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#65?email_source=notifications&email_token=ABJEC74H253E2HE2R2MLMRTQMLBVXA5CNFSM4I4DROS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD772RII#issuecomment-536848545>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJEC7ZURTF4E6YIWUHWEXDQMLBVXANCNFSM4I4DROSQ> .

[jfparadis]

@michaelfig Thanks for the info!

Would you know of a test that fails?

[jfparadis]

@Jack-Works, good trick, and it works.

Normally, cleanupSource removes ESM. An easy way to check that is to remove the call to cleanupSource() in unsafeRec and run the tests. You get something like:

ReferenceError: _d39‍ is not defined

But instead I'm passing the unsafe global as an argument. It's a little more obvious. I've check that this approach also defeats ESM detection by removing the call to cleanupSource() in a manual test.

[michaelfig]

Here is a test that fails:

npm run build
node -r esm
import Realm from '.';
r = Realm.makeRootRealm();

Expected result: Realm {}

Actual result:

Thrown:
ReferenceError: _e85‍ is not defined
    at repairFunction (eval at createNewUnsafeRec (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:704:16), <anonymous>:17:7)
    at repairFunctions (eval at createNewUnsafeRec (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:704:16), <anonymous>:75:3)
    at eval (eval at createNewUnsafeRec (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:704:16), <anonymous>:79:3)
    at eval (<anonymous>)
    at createNewUnsafeRec (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:704:16)
    at initRootRealm (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:1442:21)
    at callAndWrapError (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:69:14)
    at Proxy.makeRootRealm (/Users/michael/agoric/cosmic-workspace/realms-shim/dist/realms-shim.cjs.js:124:7)
    at repl:1
    at Script.runInThisContext (vm.js:123:20)

This error happened before #54 was merged, in commit hash 46d17c1404f4e4d3883c5cf3a70eb6a89ce7ef2e.

[michaelfig]

Need less magic in cleanupSources.

[michaelfig]

This is getting really close!

Can you please focus the regexp a little more rather than just relying on (0,any(thing), after a zero comma) to mean (0, eval)? I'd suggest changing the calls to ('indirectEval', eval) and then matching on that pattern.

[jfparadis]

How about we implement the fix from the "other" branch?

export function cleanupSource(src) {

  // Restore eval which is modified by esm module.
  // (0, eval) => (0, _<something>.e)
  src = src.replace(/\(0, _[^.]+\.e\)/g, '(0, eval)');

  // Restore Reflect which is modified by esm module.
  // Reflect => _<something>.e.Reflect
  src = src.replace(/_[^.]+\.g\.Reflect/g, 'Reflect');

  // Remove code coverage which is injected by nyc module.
  src = src.replace(/cov_[^+]+\+\+[;,]/g, '');

  return src;
}

[michaelfig]

LGTM!

[jfparadis]

@michaelfig Many thanks.