evaluators.js: allow transform.rewrite() to change endowments #38
Conversation
This reordering of the transforms phasing makes it possible for a rewriter to affect the actual endowments.
There was a problem hiding this comment.
Does rs stand for "rewriter state"? Does a rewriter state now consist of { src, endowments }? If so, transform.rewrite(rs) now transforms such a rewriter state, meaning it can transform src and endowments together, yes?
If so, why is there still a transform.endow? Why is there still the reduce on line 98 of evaluators.js ?
Correct.
I was hesitant to make a breaking change, but I will happily remove |
This reordering of the transforms phasing makes it possible for a
rewriter to affect the actual endowments.
I found I need this in order to implement the
import()expression transform correctly: it is a source-dependent endowment that can't easily be defined before the rewrite transform takes place without terrible hacks.