fix(xsnap): Avoid snapshot data memory leak #9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c9db8f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56ffe750.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-9316-xsnap-snapshot-m.agoric-sdk.pages.dev |
gibson042
force-pushed
the
gibson-9316-xsnap-snapshot-memory-leak
branch
2 times, most recently
from
275a050
to
0461c7f
Compare
gibson042
changed the title
mhofman
approved these changes
May 25, 2024
packages/xsnap/package.json
Outdated
| @@ -33,6 +33,7 @@ | |||
| "@endo/bundle-source": "^3.2.3", | |||
| "@endo/eventual-send": "^1.2.2", | |||
| "@endo/init": "^1.1.2", | |||
| "@endo/nat": "^5.0.7", | |||
There was a problem hiding this comment.
This should be in devDependencies
| @@ -87,7 +157,7 @@ export async function xsnap(options) { | |||
| netstringMaxChunkSize = undefined, | |||
| parserBufferSize = undefined, | |||
| snapshotStream, | |||
There was a problem hiding this comment.
Given our findings in https://gist.github.com/mhofman/7fbfd71048148b97089993bb4463b465 I am slightly conflicted about keeping this snapshotStream binding in the surrounding scope of makeSnapshotStream, but then the only major engine that seems to not support split scopes (JSC) would also need options to be nulled too, or skipped altogether (deconstructed in the params)
gibson042
force-pushed
the
gibson-9316-xsnap-snapshot-memory-leak
branch
from
0461c7f
to
63cbd93
Compare
This removes the need to explicitly clear its value.
gibson042
force-pushed
the
gibson-9316-xsnap-snapshot-memory-leak
branch
from
63cbd93
to
c9db8f8
Compare
mhofman
pushed a commit
that referenced
this pull request
May 30, 2024
Fixes #9316 Add testing code to observe memory leaks related to xsnap snapshots, and fix the leak that retains them. None. None. None. Covered! None (this is kernel code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9316
Description
Add testing code to observe memory leaks related to xsnap snapshots, and fix the leak that retains them.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
Covered!
Upgrade Considerations
None (this is kernel code).