Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict liveslots test env with upgrade tools #10126

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Sep 21, 2024

closes: #9126

Best reviewed commit-by-commit

Description

This PR add a new prepare-strict-test-env.js which enforces durable requirements on the baggage and provide helpers to simulate upgrades based on the helper from the async-flow and zone package tests.

In particular it adds a new startLife helper which enforces kind redefinition rules for a build step, and rejects previously watched promises (assuming they were all decided by the previous incarnation).

Security Considerations

None, test infra only

Scaling Considerations

None

Documentation Considerations

Some types added and clarified. Internal tooling

Testing Considerations

Adds tests of the new strict env and startLife helper.
Add liveslots based test in vow using the new startLife helper.
Updated the test environments in the zone and async-flow package to use the new liveslots env, but does not update the async-flow tests to use the stricter startLife (will be done in #9933 or #9383)

Upgrade Considerations

Better upgrade testing without needing a full swingset kernel

Copy link

cloudflare-workers-and-pages bot commented Sep 21, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f6d8c7
Status: ✅  Deploy successful!
Preview URL: https://1c792974.agoric-sdk.pages.dev
Branch Preview URL: https://mhofman-9126-higher-fidelity.agoric-sdk.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

old vow watch not woken up by fulfillment in new incarnation.
1 participant