Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup chain info #10108

Merged
merged 3 commits into from
Sep 18, 2024
Merged

chore: cleanup chain info #10108

merged 3 commits into from
Sep 18, 2024

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Sep 18, 2024

refs: #9807

Description

  • Removes counterparty.prefix.key_prefix: 'FIXME' from every agoricNames.chainConnection entry in vstorage
  • Removes agoricNames.chain.agoriclocal from vstorage

Security Considerations

n/a

Scaling Considerations

Incidentally reduces storage used on chain by writing less data to vstorage

Documentation Considerations

n/a

Testing Considerations

Existing tests were modified to accommodate these deletions.

Upgrade Considerations

We've yet to run init-orchestration.js, so this does not have upgrade considerations. It should be part of upgrade-17, though.

- the field is both unused by any code and unpopulated ('FIXME')
- refs: #9807
@0xpatrickdev 0xpatrickdev added the force:integration Force integration tests to run on PR label Sep 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a1c91c
Status: ✅  Deploy successful!
Preview URL: https://4ae66cf1.agoric-sdk.pages.dev
Branch Preview URL: https://9807-chain-info.agoric-sdk.pages.dev

View logs

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@0xpatrickdev 0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Sep 18, 2024
@mergify mergify bot merged commit f6ca68a into master Sep 18, 2024
97 of 105 checks passed
@mergify mergify bot deleted the 9807-chain-info branch September 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants