chore: Initialize dev-upgrade-17 #10088
Conversation
There was a problem hiding this comment.
There is a change missing to upgrade.go regarding isPrimaryUpgradeName.
the existing a3p-integration/package.json
"fromTag": "use-vaults-auctions"still seems correct
Right, this got changed in #10056 as we decided to move away from always using latest.
leaving "s:stake-bld" and "z:acceptance" proposals rather than merging them into "a:upgrade-17"
We may have decided to introduce acceptance testing as a "proposal" after these instructions was written.
I'll open a separate PR to update the maintainers and possibly the release script. Issue #10089
golang/cosmos/app/upgrade.go
Outdated
| "agoric-upgrade-17", | ||
| "agorictest-upgrade-17", |
There was a problem hiding this comment.
Ah I now remember another change we decided in the last upgrade: drop the agorictest upgrade handler names, and instead make sure we have a agoric-upgrade-17-2 available to re-apply the upgrade if necessary.
I suppose this may require a change in the release notes script as well.
https://github.com/Agoric/agoric-sdk/blob/agoric-upgrade-16/golang/cosmos/app/upgrade.go#L14-L15
There was a problem hiding this comment.
There is a change missing to isPrimaryUpgradeName
There was a problem hiding this comment.
Yeah, thanks. I think I'd like to refactor that function, but will do so on master. Updated here to keep the current form.
Deploying agoric-sdk with
|
| Latest commit: |
ea47c4c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1720909.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-09-init-upgrade.agoric-sdk.pages.dev |
gibson042
force-pushed
the
gibson-2024-09-init-upgrade-17
branch
from
45c9ff5
to
ea47c4c
Compare
Description
Bumps the cosmos upgrade handler and renames a3p-integration/proposals/n:upgrade-next to a:upgrade-17. This is mostly as described in MAINTAINERS.md, but the existing a3p-integration/package.json
"fromTag": "use-vaults-auctions"still seems correct and leaving "s:stake-bld" and "z:acceptance" proposals rather than merging them into "a:upgrade-17".Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
To be included in the full release.
Testing Considerations
No post-proposal tests are added, but they may come in later pull requests.
Upgrade Considerations
This will go through the usual validation.