Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Update Python SDK with fern #2030

Merged
merged 5 commits into from
Aug 28, 2024
Merged

[SDK] Update Python SDK with fern #2030

merged 5 commits into from
Aug 28, 2024

Conversation

jp-agenta
Copy link
Contributor

@jp-agenta jp-agenta commented Aug 28, 2024

Description

  • Updated the fern readme.md file.
  • Updated Python SDK using fern.
  • Updated SDK (tracing) based on the above.

QA

  • both in oss local and in cloud.staging.agenta.ai

Checklist

  • serve custom app, from CLI
  • get app config, from SDK
  • re-serve app, from CLI
  • test custom app, from Playground

Acceptance Criteria

  • variant being created, in Overview view
  • config being retrieved, in local code
  • inline trace being shown, in Playground view
  • traces being shown, in Observability view

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:27pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:27pm

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 28, 2024
@jp-agenta
Copy link
Contributor Author

oss fails because oss.agenta.ai is failing.

Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @jp-agenta! All 128 files changes LGTM. 🫡

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 28, 2024
@aybruhm
Copy link
Member

aybruhm commented Aug 28, 2024

QA Report

Deployment:

  • Publish pre-release to PyPI
  • Deploy to staging environment

Checklist:

  • Serve custom app, from CLI
  • Get app config, from SDK
  • Re-serve app, from CLI
  • Test custom app, from Playground

Acceptance Criteria:

  • Variant successfully created, in Overview view
  • Config retrieved correctly, in local code
  • Inline trace displayed as expected, in Playground view
  • Traces visible and accurate, in Observability view

All items in the checklist have been verified, and acceptance criteria for this PR have been met.

@jp-agenta jp-agenta merged commit f958677 into main Aug 28, 2024
9 of 10 checks passed
@jp-agenta jp-agenta deleted the fix/update-fern branch August 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend CLI lgtm This PR has been approved by a maintainer python Pull requests that update Python code SDK size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants