Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: support gmail & yahoo smtp check by api #88

Merged
merged 15 commits into from
Jun 19, 2023

Conversation

OisCircle
Copy link
Contributor

@OisCircle OisCircle commented May 4, 2023

Background

Add support of smtp check by api

What's changed

  1. specific host check smtp by api
  2. enable gmail & yahoo check by api

@OisCircle
Copy link
Contributor Author

OisCircle commented May 4, 2023

PR in draft status, waitting to add tests and fix CI.

@lryong lryong marked this pull request as ready for review May 11, 2023 10:53
Copy link
Contributor Author

@OisCircle OisCircle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@OisCircle OisCircle requested a review from lryong May 14, 2023 14:52
smtp_by_api_yahoo.go Show resolved Hide resolved
smtp.go Show resolved Hide resolved
@lryong lryong requested review from git-hulk and NeoCN May 18, 2023 01:51
verifier.go Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

@OisCircle @lryong I'm not familiar with the email vendor, so not sure if it has any risks in using the signup process to check if the user exists. If yes, I think we should add some comments to notice this. Others are good to me and left one comment inline.

@lryong
Copy link
Contributor

lryong commented Jun 13, 2023

Since it is not practical to check the existence of email addresses through smtp protocol, we have researched that large free email providers such as gmail and yahoo can check email addresses through relevant API interface methods, so we try to add the ability to check the validity of email addresses here.
For more information, please refer to check-if-email-exists/blob/master/core/src/smtp/yahoo.rs

@git-hulk @NeoCN

@git-hulk
Copy link
Member

Since it is not practical to check the existence of email addresses through smtp protocol, we have researched that large free email providers such as gmail and yahoo can check email addresses through relevant API interface methods, so we try to add the ability to check the validity of email addresses here. For more information, please refer to check-if-email-exists/blob/master/core/src/smtp/yahoo.rs

@git-hulk @NeoCN

Yes, it sounds good. Need to take care of the risks if plan to use it in production.

@OisCircle OisCircle closed this Jun 14, 2023
@OisCircle OisCircle reopened this Jun 14, 2023
@OisCircle
Copy link
Contributor Author

Since it is not practical to check the existence of email addresses through smtp protocol, we have researched that large free email providers such as gmail and yahoo can check email addresses through relevant API interface methods, so we try to add the ability to check the validity of email addresses here. For more information, please refer to check-if-email-exists/blob/master/core/src/smtp/yahoo.rs

@git-hulk @NeoCN

I have added comments to inform the user about the potential risks and related knowledge on abusing.

@git-hulk git-hulk merged commit 28ab891 into AfterShip:main Jun 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants