Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Remove CAP_NET_BIND_SERVICE capability #5692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xduugu
Copy link

@xduugu xduugu commented Apr 5, 2023

The capability was added in commit 58868b7, but since then, the USER instruction was removed from the Dockerfile, so that Adguard Home runs as root by default.

Even if it is run as non-root user, the capability is not required in docker versions >= 20.10.0 (released on Dec 9, 2020), because of commit 888da28[1], which sets net.ipv4.ip_unprivileged_port_start to 0 by default. Users running older docker versions or using the host network mode can still configure this sysctl manually.

[1] moby/moby@888da28

The capability was added in commit 58868b7, but since then, the USER
instruction was removed from the Dockerfile, so that Adguard Home runs
as root by default.

Even if it is run as non-root user, the capability is not required in
docker versions >= 20.10.0 (released on Dec 9, 2020), because of commit
888da28[1], which sets `net.ipv4.ip_unprivileged_port_start` to `0` by
default. Users running older docker versions or using the `host` network
mode can still configure this sysctl manually.

[1] moby/moby@888da28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant