Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify implementation of search #62

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Modify implementation of search #62

merged 7 commits into from
Oct 17, 2023

Conversation

AriellaCallista
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...java/seedu/address/logic/commands/ListCommand.java 54.54% <ø> (-3.79%) ⬇️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 88.88% <100.00%> (+2.00%) ⬆️
...java/seedu/address/logic/commands/FindCommand.java 90.90% <81.81%> (-0.40%) ⬇️
.../seedu/address/logic/parser/FindCommandParser.java 86.95% <81.81%> (-6.38%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

sk2001git
sk2001git approved these changes Oct 17, 2023
View reviewed changes
Copy link

@sk2001git sk2001git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AriellaCallista AriellaCallista merged commit b256201 into AY2324S1-CS2103T-W09-4:master Oct 17, 2023
5 checks passed
@AriellaCallista AriellaCallista added this to the v1.2b milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk2001git sk2001git sk2001git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2b
Development

Successfully merging this pull request may close these issues.
2 participants
@AriellaCallista @sk2001git