Branch ug final (Bug fix + UG / DG change) #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to issue AY2324S1-CS2103T-W09-4#232, additionally fix UG and DG to adapt to this change
…into branch-UG-final
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage 72.84% 72.84%
Complexity 916 916
=========================================
Files 126 126
Lines 3071 3071
Branches 375 375
=========================================
Hits 2237 2237
Misses 732 732
Partials 102 102 ☔ View full report in Codecov by Sentry. |
sk2001git
merged commit 5d92af4
into
AY2324S1-CS2103T-W09-4:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #232 , major bug fix for filter. This was caused due to changes in getTag implementation due to another bug. Fix in filtercommandparser. Refer to the closed issue for more info. Additionally updated UG and DG to match this fix.