Skip to content

Commit

Permalink
fix(acbs/utils.py): use ~dirty suffix for uncommited tree
Browse files Browse the repository at this point in the history
Previously, when we used -dirty, the second dash (-) was considered the actual
delimiter for REL. If the previous package version already contained a REL
(now the first dash), then the segment between the beginning and the second
dash would be considered the VER - making the package version higher than
any comparable candidate without the -dirty suffix.

Revise -dirty as ~dirty to close this loophole.
  • Loading branch information
MingcongBai committed Sep 7, 2024
1 parent 859f207 commit d014d6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion acbs/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def generate_version_stamp(task: ACBSPackageInfo) -> str:
)
stamp += 'Z'
if dirty:
stamp += '-dirty'
stamp += '~dirty'
logging.info(f'Using version stamp: {stamp}')
return stamp
except subprocess.CalledProcessError as ex:
Expand Down

0 comments on commit d014d6d

Please sign in to comment.