Fix Eigen Plugins compilation when linking to grid_map_core #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
commented
Jul 31, 2024
| @@ -5,8 +5,7 @@ project(grid_map_core) | |||
| find_package(ament_cmake REQUIRED) | |||
| find_package(grid_map_cmake_helpers REQUIRED) | |||
|
|
|||
| ## Define Eigen addons. | |||
| include(cmake/${PROJECT_NAME}-extras.cmake) | |||
There was a problem hiding this comment.
This needs to be moved down till after the library is created. You can't call target_compile_definitions on a target until the target exists.
| ) | ||
| ament_package() | ||
| #ament_package(CONFIG_EXTRAS | ||
| # cmake/${PROJECT_NAME}-extras.cmake |
There was a problem hiding this comment.
This breaks if we leave it in - any tips on how to test the plugins are working in another package?
|
Just adding my $0.02 that this PR does fix the Eigen linker issues when using grid_map_core for me, thank you! I can't speak to its potential impact on other plugins, though. |
Thanks for sharing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Here's a proposed patch for #382. Because the original PR for adding the plugins through CMake and ament is not well documented, I really don't know how this will affect others. Please try this PR out. It will stay open for a while until I get a reasonable number of approvals it doesn't break anything.
Test instructions
colcon build --packages-up-to issue382And try building your own packages that link to grid_map_core.