Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Indices of the inpaint filter #461

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

ipa-dmo
Copy link

@ipa-dmo ipa-dmo commented Jun 11, 2024

The inpaint filter does not use the correct indices when creating the new grid map layer.

This issue is also included in the iron release.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jul 19, 2024

Hello. Can you please target this to rolling. Then, we can backport it. Thanks for the submission.

@ipa-dmo ipa-dmo changed the base branch from iron to rolling July 19, 2024 07:58
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jul 22, 2024

Also, do you have any recommendations on how to write an automated test to verify the fix?

@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Jul 28, 2024
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jul 28, 2024

Even if not automated, do you have any recommendations on how I can verify this is correct, or reproduce the problem before this patch is applied? I am not yet familiar with this part of the codebase.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants