Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nav2_costmap_2d linkage #452

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Mar 11, 2024

Purpose

  • Upstream nav2 didn't backport the dependencies
  • Many dependencies were not linked in grid_map, or relied on transitively
  • You should link the same number of dependencies you call find_package for

Ticket

Relates to #450

Instructions

  • source /opt/ros/iron/setup.bash
  • colcon build --packages-up-to grid_map_costmap_2d

Logs

Starting >>> grid_map_costmap_2d
--- stderr: grid_map_costmap_2d                             
In file included from /opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp:20,
                 from /opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/lifecycle_node.hpp:89,
                 from /opt/ros/iron/include/nav2_costmap_2d/costmap_2d_publisher.hpp:46,
                 from /opt/ros/iron/include/nav2_costmap_2d/costmap_2d_ros.hpp:48,
                 from /home/ryan/Dev/ros2_ws/src/grid_map/grid_map_costmap_2d/test/test_costmap_2d_ros.hpp:23,
                 from /home/ryan/Dev/ros2_ws/src/grid_map/grid_map_costmap_2d/test/test_costmap_2d_ros.cpp:17:
/opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/state.hpp:21:10: fatal error: rcl_lifecycle/data_types.h: No such file or directory
   21 | #include "rcl_lifecycle/data_types.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [test/CMakeFiles/costmap-2d-ros-test.dir/build.make:76: test/CMakeFiles/costmap-2d-ros-test.dir/test_costmap_2d_ros.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:230: test/CMakeFiles/costmap-2d-ros-test.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
In file included from /opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp:20,
                 from /opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/lifecycle_node.hpp:89,
                 from /opt/ros/iron/include/nav2_costmap_2d/costmap_2d_publisher.hpp:46,
                 from /opt/ros/iron/include/nav2_costmap_2d/costmap_2d_ros.hpp:48,
                 from /home/ryan/Dev/ros2_ws/src/grid_map/grid_map_costmap_2d/include/grid_map_costmap_2d/costmap_2d_converter.hpp:22,
                 from /home/ryan/Dev/ros2_ws/src/grid_map/grid_map_costmap_2d/include/grid_map_costmap_2d/grid_map_costmap_2d.hpp:13,
                 from /home/ryan/Dev/ros2_ws/src/grid_map/grid_map_costmap_2d/test/test_costmap_2d_converter.cpp:18:
/opt/ros/iron/include/rclcpp_lifecycle/rclcpp_lifecycle/state.hpp:21:10: fatal error: rcl_lifecycle/data_types.h: No such file or directory
   21 | #include "rcl_lifecycle/data_types.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [test/CMakeFiles/grid_map_costmap_2d-test.dir/build.make:90: test/CMakeFiles/grid_map_costmap_2d-test.dir/test_costmap_2d_converter.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:202: test/CMakeFiles/grid_map_costmap_2d-test.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< grid_map_costmap_2d [0.36s, exited with code 2]

@Ryanf55 Ryanf55 self-assigned this Mar 11, 2024
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Mar 11, 2024

@wep21 I am unable to get iron to build. If you have any tips, let me know!

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Jul 28, 2024

After some time, the changes in NAV2 are available in binaries. This builds now.

@Ryanf55 Ryanf55 marked this pull request as ready for review July 28, 2024 17:04
@Ryanf55 Ryanf55 requested a review from wep21 July 28, 2024 17:04
@Ryanf55 Ryanf55 changed the base branch from iron to rolling July 28, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant