Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative paths of postgis extension #252

Closed
wants to merge 1 commit into from

Conversation

dkniffin
Copy link

@dkniffin dkniffin commented Jul 11, 2017

I worked with @prawl to find the solution for #251. Here's a PR of that change.

@keeganbrown
Copy link

+1

@gclough
Copy link
Collaborator

gclough commented Mar 26, 2018

Do we need to use the "../" anyway? I have modified #310 to remove the prefix altogether, as Ansible always assumes "./vars", so in it's current state it does "./vars/../vars", which seems a bit odd.

The new docker tests have been updated to install and verify it's working, so can you check my work to make sure it's OK for you? It's not merged into the master branch yet...

@gclough
Copy link
Collaborator

gclough commented Mar 26, 2018

Actually by using "{{ ansible_distribution_release }}", it's never going to load anything, because the files in vars are based on the {{ ansible_os_family }} variable.

... plus, at this point in the code it doesn't need to, as the variables have already been loaded in earlier, right?

@gclough
Copy link
Collaborator

gclough commented Mar 26, 2018

FYI... this is the output on my server. "Core"

TASK [postgresql : debug] ************************************************************************
ok: [192.168.45.84] => {
    "ansible_distribution_release": "Core"
}

@aoyawale
Copy link
Contributor

@gclough so does your PR fix this issue and we don't need this one ?

@gclough
Copy link
Collaborator

gclough commented Apr 3, 2018

@jlozadad, I'm pretty sure it does as all Travis tests pass... and I've included a test install of PostGIS into the tests. I've just squashed all of the commits, and basically I've removed the variables section altogether... because these are included in the main.yml file, so they don't need including again in here. Right?

@aoyawale
Copy link
Contributor

aoyawale commented Apr 3, 2018

right. so ill give it a few days then if nobody has any concern then we can close this one.

@aoyawale aoyawale closed this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants