Named SoA Support #4163
Open
Named SoA Support #4163
+163
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-named-soa
branch
from
15145a6
to
57ee5c2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| m_defined = true; | ||
| m_runtime_rdata.resize(a_num_runtime_real); | ||
| m_runtime_idata.resize(a_num_runtime_int ); | ||
| m_rdata_names = soa_rdata_names; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
| { | ||
| m_defined = true; | ||
| m_runtime_rdata.resize(a_num_runtime_real); | ||
| m_runtime_idata.resize(a_num_runtime_int ); | ||
| m_rdata_names = soa_rdata_names; | ||
| m_idata_names = soa_idata_names; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
Add support to optionally name SoA Real and Int components, both for compile-time and runtime components.
ax3l
force-pushed
the
topic-named-soa
branch
from
57ee5c2
to
9986eef
Compare
ax3l
commented
Sep 23, 2024
Comment on lines
+68
to
+87
| int first_r_name = 0; | ||
| // push back x,y,z | ||
| if constexpr (ParticleType::is_soa_particle) { | ||
| constexpr int x_in_ascii = 120; | ||
| for (int i=0; i<AMREX_SPACEDIM; ++i) | ||
| { | ||
| std::string const name{char(x_in_ascii+i)}; | ||
| m_soa_rdata_names.push_back(name); | ||
| } | ||
| first_r_name = AMREX_SPACEDIM; | ||
| } | ||
| for (int i=first_r_name; i<NArrayReal; ++i) | ||
| { | ||
| m_soa_rdata_names.push_back("real_comp" + std::to_string(i-first_r_name)); | ||
| } | ||
| for (int i=0; i<NArrayInt; ++i) | ||
| { | ||
| m_soa_idata_names.push_back("int_comp" + std::to_string(i)); | ||
| } | ||
|
|
There was a problem hiding this comment.
We discussed that we want to make this two functions (one for real, one for int) that take the ParticleType and index to return a default name on the current index.
This way, we can reuse this in the:
- current I/O logic (existing naming scheme we took over here)
- here
- in
AddRealComp/AddIntCompwithoutnameargument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to optionally name SoA Real and Int components, both for compile-time and runtime components.
Get*Data(std::string)GetData()with named indicesAddReal/IntCompAdditional background
Close #3614
Checklist
The proposed changes: