Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParmParse: Prefix to FILE #4126

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 3, 2024

Summary

For CI/CD workflows and out-of-source tests we often want to include dependent inputs files via FILE = <filename>. For development, we prefer to run in temporary run directories but want to avoid having to copy over the latest inputs file from a source directory (mostly to avoid confusion between source and copy and to enable rapid development cycles).

Now, the environment variable AMREX_INPUTS_FILE_PREFIX can be set to prefix every FILE = <filename> with a custom path. We will use this in the CTests integration of WarpX.

Additional background

CC @EZoni
ECP-WarpX/WarpX#5068

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

For CI/CD workflows and out-of-source tests we often want to include
dependent inputs files via `FILE = <filename>`. For development, we
often want to run in temporary run directories but want to avoid
having to copy over the latest inputs file from a source directory.

Now, the environment variable `AMREX_INPUTS_FILE_PREFIX`
can be set to prefix every `FILE = <filename>` with a custom path.
We will use this in the CTests integration of WarpX.
@ax3l ax3l mentioned this pull request Sep 3, 2024
21 tasks
Src/Base/AMReX_ParmParse.cpp Outdated Show resolved Hide resolved
@ax3l
Copy link
Member Author

ax3l commented Sep 5, 2024

Checked by @EZoni today: this should be ready for merge now :)

@WeiqunZhang WeiqunZhang merged commit 216ce6f into AMReX-Codes:development Sep 5, 2024
59 checks passed
@ax3l ax3l deleted the topic-pp-prefix branch September 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants