Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time integrator interface updates #4088

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

gardner48
Copy link
Contributor

@gardner48 gardner48 commented Aug 17, 2024

Summary

Remove const on input state to time integrator right-hand side (RHS) functions to allow filling ghost cells within the RHS call. Remove the set_pre_rhs_action and set_post_update functions in the time integrator interface. Update documentation to reflect changes from #3984.

Additional background

Before the updates in #3984 a set_post_update was used attach a function for filling ghost cells after computing a new stage or solution in a time integrator. #3984 expanded the time integrator interface with SUNDIALS to support implicit and ImEx methods which require updating the ghost cells for RHS evaluations inside iterative solvers. To support these methods, a new set_pre_rhs_action function was added to attach a function for filling ghost cells. This created some confusion/inconsistencies in how to fill ghost cells between explicit and implicit methods. To simplify things, this PR removes const from the input state to a RHS function so its ghost cells can be filled as part of the RHS callback and removes the pre_rhs_action/set_post_update functions.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

cc: @ajnonaka

Copy link
Contributor

@ajnonaka ajnonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amrex-tutorial SUNDIALS example checks out fine. Thanks for the updates and the documentation!

@ajnonaka ajnonaka merged commit 6dcaa12 into AMReX-Codes:development Aug 19, 2024
71 of 72 checks passed
@gardner48 gardner48 deleted the remove-pre-rhs-action branch August 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants