STL example code #126
Merged
STL example code #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduce a plot of a geometry with an stl file. The inputs file also has been updated accordingly.
|
The generated plot file should give you the volume of airfoil. |
WeiqunZhang
requested changes
Jul 1, 2024
ExampleCodes/EB/STLtest/inputs
Outdated
|
|
||
| eb2.stl_scale = 1 # default is 1 | ||
| eb2.stl_center = 0 0 0 # default is (0,0,0) | ||
| eb2.stl_reverse_normal = 1 # default is 0. use "1" to see the volume of the stl object |
There was a problem hiding this comment.
Since this is in amrex-tutorials and this parameter stl_reverse_normal is rarely used, we might want to remove this. To "see" the volume of the stl object, we could make a new MultiFab in the code to store 1-volfrac.
There was a problem hiding this comment.
I edited the main file to draw the stl object. However, I suggest keeping the eb2.stl_reverse_normal option in the input file to inform users that this parameter exists. We have used this in some PeleC test cases.
…the object needs to be fixed
…lot the stl object.
WeiqunZhang
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the example code for the STL test main file needed some edits, as EB2::Build has been updated. The current example inputs file is not compatible with the latest AMReX codes.