Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the convergence details for hse_convergence #2946

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Aug 20, 2024

the best results now come from use_pslope and reflecting BCs this is because of work we've done since the README was last updated.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

the best results now come from use_pslope and reflecting BCs
this is because of work we've done since the README was last
updated.
@zingale zingale merged commit 0896c6f into AMReX-Astro:development Aug 28, 2024
25 checks passed
@zingale zingale deleted the update_hse_convergence branch August 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants