-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit artificial viscosity if it breaks species conservation #2937
Open
zingale
wants to merge
11
commits into
AMReX-Astro:development
Choose a base branch
from
zingale:avisc_species
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 28, 2024
-
clean up the artifical viscosity routines
we just need to compute divu on the face once this is prep for limiting the artifical viscosity coefficient for species conservation
Configuration menu - View commit details
-
Copy full SHA for 0f4a868 - Browse repository at this point
Copy the full SHA 0f4a868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 660f4e9 - Browse repository at this point
Copy the full SHA 660f4e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bbde6d - Browse repository at this point
Copy the full SHA 9bbde6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for effe094 - Browse repository at this point
Copy the full SHA effe094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9253308 - Browse repository at this point
Copy the full SHA 9253308View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ed846 - Browse repository at this point
Copy the full SHA 76ed846View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8949302 - Browse repository at this point
Copy the full SHA 8949302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4410afd - Browse repository at this point
Copy the full SHA 4410afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c7707 - Browse repository at this point
Copy the full SHA c7c7707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c57182 - Browse repository at this point
Copy the full SHA 8c57182View commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48ebed2 - Browse repository at this point
Copy the full SHA 48ebed2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.