Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't compute hybrid momentum sources unless needed #2929

Closed

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 26, 2024

if we compile with USE_HYBRID_MOMENTUM=TRUE but run with castro.hybrid_hydro=0, we were still computing the hybrid_sources. These are not needed.

This logic now mirrors the rotation logic.

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

if we compile with USE_HYBRID_MOMENTUM=TRUE but run with
castro.hybrid_hydro=0, we were still computing the hybrid_sources.
These are not needed.
@zingale
Copy link
Member Author

zingale commented Jul 26, 2024

closes #2442

@zingale
Copy link
Member Author

zingale commented Jul 26, 2024

it occurs to me now that we might still want the sources though, even if we are not using the hybrid momentum to replace the linear momentum, since we still have the hybrid momentum components in the StateData / plotfiles.

So maybe the alternative is to just disable USE_HYBRID_MOMENTUM in wdmerger by default, since we are not using it.

@zingale
Copy link
Member Author

zingale commented Jul 26, 2024

closing this -- I think the current behavior is correct. Because otherwise, the state variables for the hybrid momentum are not correct, even though they are never coupled into the system.

@zingale zingale closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant