Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pstar convergence in exact_riemann use std::abs() #2898

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix pstar convergence in exact_riemann use std::abs() #2898

merged 4 commits into from
Jul 9, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 1, 2024 •
edited
Loading

PR summary

This eliminates the test on ustar_l - ustar_r, since that is tricky when u -> 0, and is not needed,
since the root solve is on pstar.

test2 now converges.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the title for pstar convergence in exact_riemann use std::abs() fix pstar convergence in exact_riemann use std::abs() Jul 1, 2024
@zingale zingale added the hydro label Jul 9, 2024
@zingale zingale merged commit b373e92 into AMReX-Astro:development Jul 9, 2024
25 checks passed
@zingale zingale deleted the fix_exact_riemann_pstar_test branch July 9, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanakbhargava khanakbhargava khanakbhargava approved these changes

Assignees
No one assigned
Labels
hydro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @khanakbhargava