Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do reactions on leaf zones when not subcycling #2523

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented Jul 9, 2023

PR summary

As a follow-up to #2505, for non-subcycling advances we can skip burning if we're not on a "leaf" zone (i.e. a zone not covered by any fine levels). These zones will be updated by an avgDown() in post_timestep().

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review July 9, 2023 22:27
@zingale
Copy link
Member

zingale commented Jul 10, 2023

@maxpkatz
Copy link
Member Author

Fixed for now by only masking on the valid zones. In a future commit we could possibly expand the functionality of makeFineMask to support ghost zones, or to be clever about it and decide whether to burn in the ghost zone based on whether the nearest valid zone is masked out.

@zingale
Copy link
Member

zingale commented Jul 11, 2023

@zingale zingale merged commit cd2cd96 into AMReX-Astro:development Jul 18, 2023
17 checks passed
@maxpkatz maxpkatz deleted the skip_burn_on_masked_zones branch July 18, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants