Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the cfl_violation parameter #2522

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Remove the cfl_violation parameter #2522

merged 3 commits into from
Jul 9, 2023

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented Jul 9, 2023

PR summary

For the CTU advance, this case is already handled by the retry functionality. For the true SDC advance, which does not yet take advantage of retries, we directly abort if a CFL violation is found.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review July 9, 2023 16:42
@zingale zingale merged commit da84929 into AMReX-Astro:development Jul 9, 2023
13 of 14 checks passed
@maxpkatz maxpkatz deleted the rm_cfl_violation branch July 9, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale